Skip to content

Fix description of pointer in ldloca.s #11314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 5, 2025
Merged

Fix description of pointer in ldloca.s #11314

merged 3 commits into from
Jul 5, 2025

Conversation

Smaug123
Copy link
Contributor

Summary

ECMA-335 6th edition states:

The ldloca instruction pushes the address of the local variable number indx onto the stack, where local variables are numbered 0 onwards. The value pushed on the stack is already aligned correctly for use with instructions like ldind and stind. The result is a managed pointer (type &).

The docs for ldloca already state that the result is a managed pointer; this PR brings the docs for ldloca.s into alignment with the spec and the docs for ldloca. (I hope that this change is in fact correct!)

@Smaug123 Smaug123 requested a review from a team as a code owner May 18, 2025 22:24
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 18, 2025
Smaug123
Smaug123 commented May 18, 2025
View reviewed changes
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 20, 2025
@gewarren gewarren added area-System.Reflection.Emit and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 20, 2025
jkotas
jkotas requested changes Jul 3, 2025
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was addressed by #9574, but this place was missed. We should apply the same change here for consistency.

@dotnet-policy-service dotnet-policy-service bot added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 3, 2025
@jkotas jkotas mentioned this pull request Jul 4, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 4, 2025
jkotas
jkotas reviewed Jul 5, 2025
View reviewed changes
jkotas
jkotas approved these changes Jul 5, 2025
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas enabled auto-merge (squash) July 5, 2025 03:37
@jkotas jkotas merged commit 03a95c5 into dotnet:main Jul 5, 2025
5 checks passed
@Smaug123 Smaug123 deleted the pointer-type branch July 5, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-System.Reflection.Emit community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Smaug123 @jkotas @gewarren